scripts/import-devices.js advertises 17 capabilities while the engine has 15 #1522
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1522
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
scripts/import-devices.js:38lists 17 capability tokens against the engine's 15 (CAPABILITIES,engine/device.js:89), and:156stripsvlan,lacpandstpand moves them intospec.role.Measured end to end on a fixture: a switch declaring 802.1Q, LACP and STP imports with capabilities
[l2-forward, l3-forward, cli], and the run reports only "1 spec(s) had minor warnings".Why it matters: the importer silently reduces what a device can do, and reports success while doing it. Any device data routed through this script - including catalogue sweeps - is quietly poorer than the source.
Suggested fix: import
CAPABILITIESfrom the engine rather than restating the list, and let the three tokens through. Where a token is genuinely not a capability, remove it from the engine set instead of stripping it in one script.