the format/version stamp is written twice and read by nothing #1520
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1520
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
formatandversionare written atengine/topology.js:560andserver/index.js:52, and read by no code anywhere. A document withversion: 99and a bogusformatloads without complaint.Why it matters: it is a guard that looks like a guard and is none - the same species as the rest of this week's findings. Anyone reading the file reasonably concludes the version is checked.
Suggested fix: either read it (refuse an unknown
format, migrate a known olderversion) or delete it and say indocs/ARCHITECTURE.mdthat documents are versionless. Accepting it and ignoring it is the one option that should not survive.