no spanning-tree vlan 10 calls a real IOS concept an unknown word #1509
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1509
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
spanning-tree vlan 10andno spanning-tree vlan 10are the same question in two directions, and they answereddifferently:
Per-VLAN STP is a real IOS concept that this model deliberately does not have; the set form says exactly that. The
noform calls it an unknown word, so an operator reading the second answer concludes the console has never heard of
per-VLAN STP — which is not what the other door says, and not true.
Neither answer is destructive (
stpPrioritysurvives both), so this is a wording defect, not a state one. It mattersbecause it is the same mechanism that #1501 exists for: the
nobranch not knowing what the set branch knows. #1501hoisted the unmodelled verbs into one list for both directions and left the one sub-command that is not a verb —
vlan— duplicated in the set branch only.Found by reviewing the queued #1501 fix before it landed, by typing both directions at the same device rather than
reading the diff.
What changes
engine/cli.js: theno spanning-treebranch answersvlanin the same terms the set form uses — one spanningtree, not one per VLAN — and names
no spanning-tree priorityas the removal that does exist.test/no-command-touches-only-what-it-names.test.js: a check that both directions agree about the concept, thatneither says "unknown sub-command", and that neither touches the priority.
Verification
no-command-touches-only-what-it-names8/8; with the previous handler 7 passed / 1 failed, the failure beingexactly this check. Lands with the queue as
land-all-v3.no spanning-tree portfastcleared the bridge priority, plus two smaller untruths in the console #1501spanning-tree vlangive the same answer (#1509) #1561