A reopened lab forgets its splitter ratio and its passive taps #1459
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1459
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A run the console refuses to draw sits in a reopened lab as a clean board.
Save that lab (at a length inside the budget), edit the saved document's
lengthMto 60000, reopen it:Cause
A document states a device's identity, its ports and its configuration.
Topology.fromJSONrebuilt the device spec from a hand-picked handful of keys (vendor, model, label, category, capabilities, interfaces) and dropped the rest. Two rules read the rest:spec.splitRatio/spec.ponClass— a 1:32 splitter came back splitting nothing, so the path lost its 17.5 dB and the budget check went quiet;isPassiveTap()readsspec.passive— a passive tap came back as a box that learns MAC addresses.What should be true
splitRatio,insertionLossDb,channelCount/channelPlan,passive,ponClass;description,notes,sourceUrl) stays out of the file.Fix:
Device.serialize()writes the spec minus the keys the document already carries elsewhere, andfromJSONmerges that record underneath the document's own identity and ports.test/spec-survives-load.test.js, 32 checks. Revertingengine/device.js+engine/topology.jsfails 14. Neighbours green:pon-splitter33,hybrid-cord-use64,cable-length22,flows-survive-save-load16,state-payload-complete16,port-roundtrip32,config-roundtrip46,engine12,acl-data21.spanning-tree portfast,vlan 20 name labanddo show vlaneach answered a different question #1493