A drag whose save fails is silent, and the canvas keeps showing a position the server does not have #1423
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1423
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
web/app.jsreports nearly every failure:api()records the failed call (so it reaches a bug report) and rethrows, and the caller shows the reason in a toast, a hint or the status bar. One caller does not:Drag a device while the server refuses the position (a refusal is now a real possibility - #1421 bounds a position to the canvas's world) or is simply not there, and:
recentErrors, i.e. in a bug report the person has not opened.The nearest thing to a guard is
test/ui-render.test.js, which loadsweb/app.jsin a stub DOM but never makes an API call fail.What should be true
catchinweb/*.jsthat wraps a call toapi()reaches the user, or carries a/* silent-ok: <reason> */marker a reviewer has to read;console.erroralone does not count - the person who clicked does not read the console, which was the finding of #20.Found while sweeping
The palette's "someone already asked for this" markers were emptied when the forge was slow:
which is not "the palette is unchanged" (the comment above it) - it is losing what it had, for the duration of a slow forge.