The per-port counters have no guard, and a drop summary nests its own brackets #1417
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1417
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The per-port tally exists in two places: the engine's flow state, which
fullState()publishes asruntime[id].counters.ports, andshow interfaces, which prints one block per port. Every other pair of surfaces in this codebase that reimplemented one rule has drifted - port state (#1238), PoE (#1293), the routes table (#1301), the switchport sentence (#1291) - and each time the drift was invisible until somebody compared them.Counters have no guard at all.
web/app.jsdoes not read them yet, so an agreement bug here would be found by whoever writes the next table or sparkline, not by us.While writing that comparison, one rendering defect turned up:
The reason is prose and it brings its own brackets, printed inside the summary's brackets. The list closes early for a reader treating it as a list, and nests for one who is not.
What should be true
drops.byReasonwith the same count, and no reason is counted that is not printed;