A ping over HTTP cannot be asked at an instant, and its packets are counted nowhere #1381
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1381
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
POST /api/topologies/:name/pingtakes{src, dst, count}and nothing else. Two things are missing from that.1. The instant.
Simulator.ping()has honouredopts.atMssince convergence was modelled, and the consolespells it
ping <address> at <ms>. The endpoint never read it, so every HTTP ping was asked at Infinity: on a labthat is still converging you cannot ask, through the API or the UI, "will this work in five seconds?" — the one
question the convergence model exists to answer. Measured on a switch whose access ports listen for 30 s:
converging, settling at 30000)2. The accounting. The endpoint ran
new Simulator(topo)— a second simulator with its own flow state — so theframes a ping sent were invisible to
/flows, while the same ping typed into the console was counted. This isdefect #1335, fixed for the console endpoint in #1337 and left standing here.
What must be true instead
atMsis accepted, validated (400 E_BAD_INSTANTfor anything that is not a time at or after 0), and passedto the engine; the answer reports
runAtMsso it cannot be mistaken for an answer about another moment.simForFlows(topo), so its frames land in the same counters/flowsreports andshow interfacesprints.atinstant sticks to the console session, and the browser calls convergence packet loss #1383