Three surfaces ask what a ping destination is, and answer it three ways #1377
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1377
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Three surfaces ask "is this a ping destination?" and answer it three ways.
engine/cli.jsping10.0.0.999, becausenet.isIp()only checks the shape (three dots, one to three digits)POST /api/topologies/:id/ping10.0.0.999threw insideSimulator.ping()and came back as a 500 — a mistyped octet presented as a server faultweb/app.jsping dialog/^(\d{1,3}\.){3}\d{1,3}$/— accepted10.0.0.999(and got the 500), refused every hostnameAfter #1376 the console resolves a name through the lab's DNS servers. The other two surfaces were not changed with
it, so the same lab answers differently depending on which door you come through.
Also:
POST /pingnever returns what the resolver said. A name that does not resolve sends no packet at all,yet the answer is only
replies: [{ success: false }]— indistinguishable from four lost echoes, so the UI draws a0% success rate for something that was never sent.
What must be true instead
address-shaped rubbish).
400with a code and a message naming the problem — not a500.{src:"nobody"}stays a404about the device it named.POST /pingreturns the resolver verdict ({ ok, status, address, serverIp }, ornullfor an address) so aresolution failure can be told from packet loss.
nothing was sent.
atinstant sticks to the console session, and the browser calls convergence packet loss #1383