The cable inspector asserts a physical-layer check that nothing ran, and load never validates #1303
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jaylouisw/packetforge#1303
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The cable inspector printed, for every cable, unconditionally:
Nothing computed that. It was a sentence in the renderer.
And there is a path that produces a cable nobody ever checked:
POST /topologies/:id/loadswaps a whole documentin with no validation at all (
Topology.fromJSON(body), straight into the map). A hand-edited file, or onewritten before a physical-layer rule existed, therefore carried an impossible cable through the entire UI wearing
the same confident sentence as a good one. Meanwhile
validateTopology()had the exact answer available — and, byits own comment, "nothing but tests ever called it".
Measured: a document whose only cable claims
10gbase-srbetween two Aruba CX 6000 RJ45 ports loads silently, andthe engine's own verdict for it is:
A 5 km copper run (
1000BASE-Treaches 100 m) loads the same way.What it must do instead
validateTopology(topo)when it builds a state payload, sostate.verdictscarries{ok, errorCount, warningCount, byLink, issues}— one verdict per cable, filed under the cable that causedit, so a panel with one cable selected does not have to filter the whole lab;
"checked by the engine, not assumed by this panel";
carries the verdict and the UI says
Imported, but 1 cable cannot be usedinstead ofTopology imported;This cable has not been checked, never the reassuring sentence;linkId(a lab-level problem) must not vanish when a cable is selected, or the panel wouldreport a clean cable inside a broken lab.