Let CI be run on demand, since main is otherwise never verified #1072

Merged
jaylouisw merged 1 commit from ci/dispatchable into main 2026-11-08 15:16:24 +00:00
Owner

ci.yml could only be triggered by a push to main or a pull request against it. Merging through the API does not reach the runner as a push event, so the default branch is the one branch nothing checks after it changes — which is how #776 landed green and left main red for hours.

workflow_dispatch makes verifying a branch something someone can choose to do, and it also kills a workaround that never worked: #930 documents pushing to a scratch ci/main-verify branch to get a run, but push: is scoped to branches: [main], so that push matches no trigger at all.

Nothing about the matrix changes — same three jobs, same Node versions, same steps.

While investigating this I found the scheduled-workflow deadlock (#1071) and the runner running with capacity: 1 on a 40-core host; both are covered there.

`ci.yml` could only be triggered by a push to `main` or a pull request against it. Merging through the API does not reach the runner as a push event, so the default branch is the one branch nothing checks after it changes — which is how #776 landed green and left `main` red for hours. `workflow_dispatch` makes verifying a branch something someone can choose to do, and it also kills a workaround that never worked: #930 documents pushing to a scratch `ci/main-verify` branch to get a run, but `push:` is scoped to `branches: [main]`, so that push matches no trigger at all. Nothing about the matrix changes — same three jobs, same Node versions, same steps. While investigating this I found the scheduled-workflow deadlock (#1071) and the runner running with `capacity: 1` on a 40-core host; both are covered there.
Let CI be run on demand, since main is otherwise never verified
Some checks failed
CI / Test (Node 18) (pull_request) Failing after 1m28s
CI / Test (Node 20) (pull_request) Failing after 1m23s
CI / Server smoke test (pull_request) Successful in 26s
CI / Docker build (pull_request) Successful in 10s
CI / Test (Node 22) (pull_request) Failing after 1m21s
551a735597
ci.yml could only be triggered by a push to main or a pull request against it.
Merging through the API does not reach the runner as a push event, so the default
branch is the one branch nothing checks after it changes - which is how #776 landed
green and left main red for hours (see #930).

workflow_dispatch makes verifying a branch a thing someone can choose to do, and
gives the next person a way to re-run the matrix against main without inventing a
scratch branch that - as #930 also found - does not match any trigger anyway.

No change to what the matrix runs.
jaylouisw scheduled this pull request to auto merge when all checks succeed 2026-11-08 15:12:06 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jaylouisw/packetforge!1072
No description provided.